-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMakeLists.txt in libs/sockets to build on buster #1768
Conversation
Should I add Debian Buster to CI? |
I'm building on that, if you want yes. |
For the sake of readability of For Debian Buster, @iliaplatone Could you please check if everything is ok? |
indi/libs/indibase/baseclient_p.h:6:10: fatal error: tcpsocket.h: No such file or directory |
It needs that for the headers at least |
{CMAKE_CURRENT_SOURCE_DIR}/ in sockets/
Oh.. some mess over there forgot to point to ${CMAKE_CURRENT_SOURCE_DIR}/ the include path |
Is the version change not enough? cmake_minimum_required(VERSION 3.13)
project(sockets CXX)
find_package(Threads REQUIRED)
add_library(${PROJECT_NAME} STATIC "")
# Headers
list(APPEND ${PROJECT_NAME}_HEADERS
tcpsocket.h
)
list(APPEND ${PROJECT_NAME}_PRIVATE_HEADERS
tcpsocket_p.h
)
# Sources
list(APPEND ${PROJECT_NAME}_SOURCES
tcpsocket.cpp
)
if(WIN32)
list(APPEND ${PROJECT_NAME}_SOURCES
tcpsocket_win.cpp
)
else()
list(APPEND ${PROJECT_NAME}_SOURCES
tcpsocket_unix.cpp
)
endif()
# Setup Target
target_sources(${PROJECT_NAME}
PUBLIC
${${PROJECT_NAME}_SOURCES}
${${PROJECT_NAME}_HEADERS}
PRIVATE
${${PROJECT_NAME}_PRIVATE_HEADERS}
)
target_include_directories(${PROJECT_NAME}
PUBLIC ./
)
target_link_libraries(${PROJECT_NAME} Threads::Threads) |
Done, it builds here also. |
To confirm, it was enough to change the version only? Do you want to merge this pull request as soon as possible? |
Yes that was enough. I can wait. |
No description provided.